Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove optional variable attribute experiment from project #1011

Merged
merged 6 commits into from
Oct 1, 2022

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Sep 30, 2022

What does this PR do?

  • Remove optional variable attribute experiment from project. This removes the version pin of < 1.3.0 from the project itself, but there is additional work still before users can use 1.3.0+ on this project. Namely, the two external addons needed to be updated

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test September 30, 2022 21:30 Inactive
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test September 30, 2022 21:41 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test September 30, 2022 21:59 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test September 30, 2022 22:09 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test September 30, 2022 22:27 Inactive
@bryantbiggs bryantbiggs marked this pull request as ready for review September 30, 2022 22:42
@bryantbiggs bryantbiggs merged commit db22d77 into main Oct 1, 2022
@bryantbiggs bryantbiggs deleted the fix/experiments branch October 1, 2022 02:31
@Hokwang
Copy link
Contributor

Hokwang commented Oct 5, 2022

@bryantbiggs tetrate_istio has also problem.

│ Error: Experiment has concluded
│
│   on .terraform/modules/eks_kubernetes_addons.tetrate_istio.cni/modules/kubernetes-addons/helm-addon/locals.tf line 2, in terraform:
│    2:   experiments = [module_variable_optional_attrs]
│
│ Experiment "module_variable_optional_attrs" is no longer available. The final feature corresponding to this experiment differs from the experimental
│ form and is available in the Terraform language from Terraform v1.3.0 onwards.
╵
╷
│ Error: Experiment has concluded
│
│   on .terraform/modules/eks_kubernetes_addons.tetrate_istio.gateway/modules/kubernetes-addons/helm-addon/locals.tf line 2, in terraform:
│    2:   experiments = [module_variable_optional_attrs]
│
│ Experiment "module_variable_optional_attrs" is no longer available. The final feature corresponding to this experiment differs from the experimental
│ form and is available in the Terraform language from Terraform v1.3.0 onwards.
╵
╷
│ Error: Experiment has concluded
│
│   on .terraform/modules/eks_kubernetes_addons.tetrate_istio.istiod/modules/kubernetes-addons/helm-addon/locals.tf line 2, in terraform:
│    2:   experiments = [module_variable_optional_attrs]
│
│ Experiment "module_variable_optional_attrs" is no longer available. The final feature corresponding to this experiment differs from the experimental
│ form and is available in the Terraform language from Terraform v1.3.0 onwards.

@Hokwang
Copy link
Contributor

Hokwang commented Oct 5, 2022

I think you can remove ondat, tetrate_istio, valut modules in main.tf. It is easy and fast way.
As you know, addon module calls other addons which is managed other repo is not good way, if we can use helm chart in this repo.

And also user can use it in their code directly.

allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants